fix ResponseMetaDataTransformer #13
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with API Gateway and trying to snapshot responses coming from AWS_PROXY Integration Subtypes, AWS will return a response containing the
ResponseMetadata
field but already filtered, with noHTTPHeaders
field in it.The current
ResponseMetaDataTransformer
will always try access theHTTPHeaders
field as a dict, even if the value fromhttp_headers = metadata.get("HTTPHeaders")
isNone
, raising this exception:As a workaround, I've implemented a hack like that:
service_resp["_ResponseMetadata"] = service_resp.pop("ResponseMetadata")
This PR now properly fixes it, and adds some test for the transformer.
I'd like to note that it seems we were trying to get the
Content-Type
header from the response, but as the value was wrong, it was never captured in any snapshots.Adding it now would need a full refresh, or a big skip, so this is out of scope of this PR.
For the release version, I'd say this could be a
0.3.1
?